Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass support #22

Open
wants to merge 5 commits into
base: step2
Choose a base branch
from
Open

Conversation

andreasonny83
Copy link

  • demo project inside the repo
  • distribution folder with the minimized version of the library for start using css-loaders in other projects
  • documentation updated
  • removed unused code
  • package.json fixed
  • other minor improvements

* demo project inside the repo
* distribution folder with the minimized version of the library for start using css-loaders in other projects
* documentation updated
* removed unused code
* package.json fixed
* other minor improvements
@lukehaas
Copy link
Owner

lukehaas commented Apr 1, 2016

@andreasonny83 thanks for making this request.
It looks like with this update compiled CSS would be part of the repo, as you haven't added the new /dist directory to gitignore. Is that something you intended?

@andreasonny83
Copy link
Author

Yes, that's right. The dist folder will be visible in the repository containing the latest stable build of the library. In this way, people can simply download the zipped version or cloning the repository and start using the cssloader in their projects without the need of installing all the node packages and compile a new version every time.

@andreasonny83
Copy link
Author

It is quite common to have a dist folder from where people can start using the library without compiling the source code. Have a look at the Twitter Bootstrap repository for example: https://github.com/twbs/bootstrap

* fix small error in fading dots animation

small glitch in 37.5 keyframe has the 100% dot set to 20%

* let box-shadow inherit colour instead of defining it
merging step2 from lukehaas/css-loader
* step2:
  let box-shadow inherit colour instead of defining it
  fix small error in fading dots animation
@andreasonny83
Copy link
Author

Hi @lukehaas, I merged your latest step2 branch inside this pull request to resolve some merge conflicts. The pull request is clean again and ready to be merged. Let me know if you're happy with this.

@lukehaas
Copy link
Owner

Thanks @andreasonny83, you're right, it's a good idea to have the compiled css available.
However, I'm not keen to have the demo site code in the repo. Also, the demo site is created in jade and compiled to html, but your updates remove the jade compilation from grunt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants