Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Invert comments on pattern trailer handling, extend test values #23

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

huntie
Copy link
Contributor

@huntie huntie commented Dec 20, 2022

Hey, I've been looking through the tests for this library and spotted something which I'd interpreted differently in the spec. Specifically, the behaviour of pattern trailers for subpath exports, described in more detail here: nodejs/node#39635.

Changes:

  • Change the two relevant comments in tests
  • Extend test values for subpath exports to include an intermediate subdirectory

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e0a914b) compared to base (587b0ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           51        52    +1     
=========================================
+ Hits            51        52    +1     
Impacted Files Coverage Δ
src/index.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/resolve.js Outdated Show resolved Hide resolved
test/resolve.js Outdated Show resolved Hide resolved
test/resolve.js Outdated Show resolved Hide resolved
test/resolve.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants