Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove esm package #214

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

chore: remove esm package #214

wants to merge 3 commits into from
+362 −287

Conversation

benmccann
Copy link

unblocks #212

the esm package doesn't support the node: protocol, so it must be removed in order to support Deno

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9656b12) to head (c2ea20e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          322       322           
=========================================
  Hits           322       322

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kobenguyent
kobenguyent reviewed Sep 4, 2024
View reviewed changes
.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
nodejs: [10, 12, 14, 16, 18]
nodejs: [12, 14, 16, 18]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also drop 12,14,16 as they reached eof for while https://endoflife.date/nodejs and add new version like 19, 20, 21?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 and 21 are EOL too. Adding 20 and 22 would be interesting.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd versions are experimental and should never be used.

@birkskyum birkskyum mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed left review comments

@kobenguyent kobenguyent kobenguyent left review comments

@birkskyum birkskyum birkskyum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benmccann @codecov-commenter @lukeed @kobenguyent @birkskyum