Merge pull request emberjs#16467 from rwjblue/exports

Cleanup / validate global exports.
lukecoy · Apr 5, 2018 · 0547703 · 0547703
2 parents d06fd50 + fcec631
commit 0547703
Show file tree

Hide file tree

Showing 8 changed files with 236 additions and 302 deletions.
diff --git a/packages/ember-application/tests/system/application_test.js b/packages/ember-application/tests/system/application_test.js
@@ -1,5 +1,5 @@
 /*globals EmberDev */
-import { VERSION } from 'ember';
+import VERSION from 'ember/version';
 import { ENV, context } from 'ember-environment';
 import { libraries, setNamespaceSearchDisabled } from 'ember-metal';
 import { getDebugFunction, setDebugFunction } from 'ember-debug';

diff --git a/packages/ember-environment/lib/index.js b/packages/ember-environment/lib/index.js
@@ -16,6 +16,10 @@ export const ENV =
   (typeof global.ENV === 'object' && global.ENV) ||
   {};
 
+export function getENV() {
+  return ENV;
+}
+
 // ENABLE_ALL_FEATURES was documented, but you can't actually enable non optional features.
 if (ENV.ENABLE_ALL_FEATURES) {
   ENV.ENABLE_OPTIONAL_FEATURES = true;
@@ -66,19 +70,6 @@ ENV.LOG_STACKTRACE_ON_DEPRECATION = defaultTrue(ENV.LOG_STACKTRACE_ON_DEPRECATIO
 */
 ENV.LOG_VERSION = defaultTrue(ENV.LOG_VERSION);
 
-/**
-  Debug parameter you can turn on. This will log all bindings that fire to
-  the console. This should be disabled in production code. Note that you
-  can also enable this from the console or temporarily.
-
-  @property LOG_BINDINGS
-  @for EmberENV
-  @type Boolean
-  @default false
-  @public
-*/
-ENV.LOG_BINDINGS = defaultFalse(ENV.LOG_BINDINGS);
-
 ENV.RAISE_ON_DEPRECATION = defaultFalse(ENV.RAISE_ON_DEPRECATION);
 
 /**
@@ -131,6 +122,14 @@ export const context = {
   lookup: originalContext.lookup || global,
 };
 
+export function getLookup() {
+  return context.lookup;
+}
+
+export function setLookup(value) {
+  context.lookup = value;
+}
+
 // TODO: cleanup single source of truth issues with this stuff
 export const environment = hasDOM
   ? {

diff --git a/packages/ember-metal/lib/libraries.js b/packages/ember-metal/lib/libraries.js
@@ -2,6 +2,8 @@ import { warn, debug } from 'ember-debug';
 import { DEBUG } from 'ember-env-flags';
 import { get } from './property_get';
 import { EMBER_LIBRARIES_ISREGISTERED } from 'ember/features';
+import VERSION from 'ember/version';
+
 /**
  @module ember
 */
@@ -82,5 +84,7 @@ if (DEBUG) {
     debug('-------------------------------');
   };
 }
+const LIBRARIES = new Libraries();
+LIBRARIES.registerCoreLibrary('Ember', VERSION);
 
-export default new Libraries();
+export default LIBRARIES;
diff --git a/packages/ember-utils/lib/index.js b/packages/ember-utils/lib/index.js
@@ -28,3 +28,6 @@ export { HAS_NATIVE_SYMBOL } from './symbol-utils';
 export { HAS_NATIVE_PROXY } from './proxy-utils';
 export { default as WeakSet } from './weak_set';
 export { isProxy, setProxy } from './is_proxy';
+
+import symbol from './symbol';
+export const NAME_KEY = symbol('NAME_KEY');