fix!: change credentials mode from "omit" to "same-origin" when set to false #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default value of the
credentials
option in fetch.Until now, it was set to
omit
if thewithCredentials
was falsy, as @oatkiller pointed out in #26.As per the spec, this value should be
same-site
by default andinclude
if thewithCredentials
option is set totrue
.Reference: https://html.spec.whatwg.org/multipage/server-sent-events.html#dom-eventsource-withcredentials-dev
Caution
This is a breaking change, as users with
withCredentials
not set or set to false, will now send cookies tosame-site
instead of sending not them.Be sure that this is acceptable for your use case.
Tip
If the
credentials
mode should still be set toomit
, you can set theomitCredentials
parameter totrue
.If
withCredentials
is also set totrue
,omitCredentials
will take precedence.