fix: Accept 'cmd' shell without exe extension for windows #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-reineke
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks
I think doing a find in string operation on every completion is unnecessarily expensive. shell is unlikely to ever change. Can you just move this into a variable at the top of the file that is evaluated once? Something like local is_cmd = string.find(vim.o.shell, "cmd")
|
@lukas-reineke I've implemented your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation requires you to forcefully use the
exeextension as the value forshell, however it is possible to only usecmdwithout extension. Checking if shell containscmdshould be fine for ether case.