Add macro to create register functions and move laplacian to single file #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a macro to automatically create
register_
functions, and moves everything that was insidelaplacian
folder to a single file (previous design was due to less robust registry; this way is simpler).The
register
macro works as follow: given aRegistry
(e.g.LaplacianFinderRegistry
) it creates a functionregister_
by removingRegistry
from the name and transforming it in snake case (e.g.register_laplacian_finder
).(This is a simple thing that may potentially make the code slightly harder to understand - you tell me @GiLonga and @gviga -, but it is annoying to create this functions every time).