Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: class name collision with native react-native-config #724

Merged
merged 7 commits into from
Jan 22, 2023

Conversation

philpettican118
Copy link
Contributor

Fixes #667

@jeremy303
Copy link

@philpettican118 Thanks so much for working on this! Practically, I'm sure this is a safe renaming, but as a heads up Apple reserves 2-letter prefixes for it's own frameworks:

In order to keep class names unique, the convention is to use prefixes on all classes. You’ll have noticed that Cocoa and Cocoa Touch class names typically start either with NS or UI. Two-letter prefixes like these are reserved by Apple for use in framework classes.

. . .

Your own classes should use three letter prefixes. These might relate to a combination of your company name and your app name, or even a specific component within your app.

@philpettican118
Copy link
Contributor Author

Hey @HolySamosa , It's using three letter prefixes i.e RNC e.g. RNCConfig

@jeremy303
Copy link

[facepalm] Duh, sorry @philpettican118 . I just realized I was only looking at one of the earlier commits. This is what I get for skipping coffee this morning...

@luancurti luancurti self-requested a review January 20, 2023 03:35
@luancurti
Copy link
Collaborator

@philpettican118 Thanks for spend your time to fix the problem. I'll take a look as soon as possible.

@luancurti luancurti merged commit d29df70 into lugg:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactNativeConfig.h name collision w/ React Native 0.68 iOS
3 participants