Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change xml style to mention package name #575

Merged
merged 1 commit into from
May 21, 2021
Merged

Change xml style to mention package name #575

merged 1 commit into from
May 21, 2021

Conversation

asukiaaa
Copy link
Contributor

I miss read to use app-id.XML for default config.
How about to change YOUR_PACKAGE_NAME_IN_ANDROIDMANIFEST.XML to YOUR_PACKAGE_NAME_IN_ANDROIDMANIFEST_XML.

Related comment:
#170 (comment)

@height
Copy link

height bot commented May 21, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@luancurti luancurti merged commit c77f2b4 into lugg:master May 21, 2021
@asukiaaa asukiaaa deleted the patch-1 branch May 25, 2021 01:43
pvinis pushed a commit to artsy/react-native-config that referenced this pull request Jan 18, 2022
@asukiaaa @pvinis
Change xml style to mention package name (lugg#575)
9bc4786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luancurti luancurti luancurti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asukiaaa @luancurti