Don't specify buildToolsVersion on Android #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're depending on a version of the Android Gradle plugin higher than 3, we don't need to specify a buildToolsVersion. Trying to grab this value from the root project, in a project that also doesn't specify it, would fail. Since the only reason we were doing the fetch was to specify our own buildToolsVersion, I think we can safely remove it.
|
|
Thanks! |
luancurti
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're depending on a version of the Android Gradle plugin higher than 3, so we don't need to specify a buildToolsVersion. Trying to grab this value from the root project, in a project that also doesn't specify it, would fail. Since the only reason we were doing the fetch was to specify our own buildToolsVersion, I think we can safely remove it.