Temporarily use safe FFTW planning #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 58.68% 58.83% +0.14%
==========================================
Files 8 8
Lines 564 566 +2
==========================================
+ Hits 331 333 +2
Misses 233 233 ☔ View full report in Codecov by Sentry. |
DiamonDinoia
reviewed
Sep 9, 2024
| @@ -45,6 +48,11 @@ include("simple.jl") | |||
|
|
|||
| # Only load cuFINUFFT interface if CUDA is present (via `using CUDA`) and functional | |||
| function __init__() | |||
|
|
|||
| # quick and dirty: make fftw thread safe | |||
There was a problem hiding this comment.
maybe marking it as a workaround referring the finufft PR would be good.
|
Thank you for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly loads
FFTW_jllto enforce thread-safe planning for FFTW hence provisorily fixing #62 . As soon as flatironinstitute/finufft#548 is merged, we can updatefinufft_jlland employ the changes over at https://github.com/jkrimmer/FINUFFT.jl/tree/user_fftw_lock instead.