Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 205 #2

Merged
merged 9 commits into from
Aug 5, 2019
Merged

Issue 205 #2

merged 9 commits into from
Aug 5, 2019

Conversation

lucventurini
Copy link
Owner

Changes:

  • Mikado now will not hang if a subprocess dies, it will immediately exit.
  • Ensured that Mikado runs are fully reproducible using a random seed (Static random seed EI-CoreBioinformatics/mikado#183)
  • Solved a bug that crashed Mikado prepare in the presence of incorrect transcripts
  • Removed the cause for locked interprocess-exchange databases in Mikado pick. Switched to WAL and increased the timeout limit.

@lucventurini
Fix EI-CoreBioinformatics#205
be3bccf
@lucventurini
Fix EI-CoreBioinformatics#205 - now Mikado should avoid crashing whil…
c5bbb68 
…e doing checks in prepare
@lucventurini
Fixes for EI-CoreBioinformatics#205
ec1d42f
@lucventurini
Fix EI-CoreBioinformatics#205 - specifically the seed setting
530fd87
@lucventurini
Fix EI-CoreBioinformatics#205 - for paranoia reasons, setting the see…
8e89834 
…d also within the processes. Moreover, I have ensured that numpy.random.seed will not crash because of a seed larger than 2^32 - 1 (the maximum limit)
@lucventurini
This should fix EI-CoreBioinformatics#205 and EI-CoreBioinformatics#183.
2f61779
@lucventurini
Corrected a mistake in .travis
c129ad4
@lucventurini
This should fix and test EI-CoreBioinformatics#183 for good. Now we r…
ccbc0bb 
…eseed (a pretty inexpensive operation) each time before drawing. This ensures that we will always have a reproducible result.
@lucventurini
Bump version
efbaa0b
@lucventurini lucventurini merged commit 68d3c60 into master Aug 5, 2019
@lucventurini lucventurini deleted the issue-205 branch August 5, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucventurini