forked from kubeflow/model-registry
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Pull Request Template for UI team
- Loading branch information
Showing
1 changed file
with
31 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<!--- If this is a non-code change, this template is not required; reference any issues or top-level descriptions as needed --> | ||
|
||
## Description | ||
<!--- Describe your changes in detail; the what, the why, any findings, etc --> | ||
<!--- Include any screenshots of changed UI; Include any gifs if it was a flow / UX change --> | ||
|
||
## How Has This Been Tested? | ||
<!--- Please describe in detail how you tested your changes. --> | ||
<!--- Include details of your testing environment, and the tests you ran to --> | ||
<!--- see how your change affects other areas of the code, etc. --> | ||
|
||
## Test Impact | ||
<!--- What tests have you done to covert implemented functionality --> | ||
<!--- If tests are not applicable, explain why here --> | ||
|
||
## Request review criteria | ||
<!--- This PR will be merged by any repository approver when it meets all the points in the checklist --> | ||
<!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
|
||
Self checklist (all need to be checked): | ||
|
||
- [ ] The developer has manually tested the changes and verified that the changes work. | ||
- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). | ||
- [ ] The developer has added tests or explained why testing cannot be added. | ||
- [ ] Code changes follow the [kubeflow contribution guidelines](https://www.kubeflow.org/docs/about/contributing/). | ||
|
||
If you have UI changes | ||
|
||
<!--- You can ignore these if you are doing manifest, backend, internal logic, etc changes; aka non-UI / visual changes --> | ||
- [ ] Included any necessary screenshots or gifs if it was a UI change. | ||
- [ ] Verify that UI/UX changes conform the UX guidelines for Kubeflow. |