Refactor data fetching and filtering logic in get.ts #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @lucavallin on Vercel. @lucavallin first needs to authorize it. |
lucavallin
reviewed
Oct 9, 2023
lucavallin
reviewed
Oct 9, 2023
lucavallin
reviewed
Oct 9, 2023
lucavallin
previously approved these changes
Oct 9, 2023
|
Thanks for the comments, I'll update the filename and the other comments
tomorrow and then merge it.
…On Mon, Oct 9, 2023, 8:23 PM Luca Cavallin ***@***.***> wrote:
***@***.**** approved this pull request.
Great work - thanks for the refactoring!
—
Reply to this email directly, view it on GitHub
<#229 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQWAE77XOIZNZKFJQNT7LLX6O7CRAVCNFSM6AAAAAA5XMWDDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRUGA2DCMRTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@lucavallin Reviews comments have been addressed and the code is ready for merging. Please let me know if there are any additional concerns. |
lucavallin
previously approved these changes
Oct 11, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dnafication Sorry for the delay! Approved, but there is a conflict. |
|
Resolved conflicts and merged the latest main. Feel free to merge it @lucavallin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor data fetching and filtering logic in get.ts
This pull request refactors the
data/get.tsfile to make it more readable and modular. The data fetching logic is now separated from the filtering logic, and reusable utility functions have been extracted into a separateutils.tsfile.The changes include:
data/get.tstodata/index.tsand converted it to use async/await syntaxshared.tsfileDatainterface to define the shape of the data file to be writtenutils.tsfileThese changes should make the code easier to read, maintain, and extend in the future.
Please review and let me know if there are any issues or concerns with these changes. Happy to discuss and make any necessary changes.
related to #206 and its discussions