-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Account statements #220
Conversation
WalkthroughThe recent updates involve refining the codebase of Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 7
Configuration used: CodeRabbit UI
Files selected for processing (2)
- pyitau/pages.py (1 hunks)
- tests/responses/checking_account_full_statement.html (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- pyitau/pages.py
Additional comments: 1
tests/responses/checking_account_full_statement.html (1)
- 150-159: The function
validaData
andadobeFiltroPeriodoExtrato
are called without any context on their implementation. Ensure these functions have proper error handling and input validation to prevent potential issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- pyitau/pages.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- pyitau/pages.py
Thank you very much, @andreroggeri |
I'm not happy with the solution since it's assuming the order of the function code, but I'm opening the PR here anyway for discussion.
I have tested this with my account, and it worked correctly.
Note: All the whitespace was automatically added by black; I can remove it if you don't agree with this style. 😅
Closes #219
Summary by CodeRabbit
consultarLancamentosPorPeriodo
function.