Update bevy to 0.11 #93
Conversation
bevy_renet/src/transport.rs
Outdated
| app.add_systems(PostUpdate, Self::send_packets.in_set(TransportSet::Server)); | ||
| app.add_systems(PostUpdate, Self::disconnect_on_exit.in_set(TransportSet::Server)); |
There was a problem hiding this comment.
Maybe group these systems in one call?
Similar for other places.
bevy_renet/src/transport.rs
Outdated
| app.add_systems(PostUpdate, Self::send_packets.in_set(TransportSet::Client)); | ||
| app.add_systems(PostUpdate, Self::disconnect_on_exit.in_set(TransportSet::Client)); |
There was a problem hiding this comment.
Could you combine these two systems too?
|
There might be a regression. As the server I am unable to obtain the IP addresses of incoming connections. |
| @@ -24,9 +24,9 @@ impl Plugin for RenetServerPlugin { | |||
| fn build(&self, app: &mut App) { | |||
| app.init_resource::<Events<ServerEvent>>(); | |||
|
|
|||
| app.configure_set(RenetSet::Server.run_if(resource_exists::<RenetServer>())); | |||
| app.configure_set(Update, RenetSet::Server.run_if(resource_exists::<RenetServer>())); | |||
There was a problem hiding this comment.
You configure set for Update, but use it in PreUpdate. I think that's the issue.
There was a problem hiding this comment.
Do we need to configure this with all default sets?
Like:
app.configure_set(PreUpdate, RenetSet::Server.run_if(resource_exists::<RenetServer>()));
app.configure_set(Update, RenetSet::Server.run_if(resource_exists::<RenetServer>()));
app.configure_set(PostUpdate, RenetSet::Server.run_if(resource_exists::<RenetServer>()));This set is used to simplify the run_if(resource_exists::<RenetServer>()
There was a problem hiding this comment.
I guess we hit this issue:
bevyengine/bevy#9139
There was a problem hiding this comment.
It seems we shouldn't be using SystemSets, and should just use directly run_if(resource_exists::<RenetServer> / run_if(resource_exists::<RenetClient>
There was a problem hiding this comment.
I will go and remove the SystemSets.
There was a problem hiding this comment.
I probably should remove the set enum too then.
This is actually not exposed in the |
|
|
Just updates bevy to 0.11, and changes some stuff to fix errors. Let me know if I should make any changes!