Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve auth API #116

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Improve auth API #116

merged 2 commits into from
Oct 4, 2023

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Oct 3, 2023

Problem

ClientAuthentication cannot be copied or cloned, which makes reconnecting a challenge. ConnectToken internals are not public (see issue #112).

Solution

  • Derive Clone on ClientAuthentication.
  • Make the internals of ConnectToken public.

@lucaspoffo lucaspoffo merged commit d91052b into lucaspoffo:master Oct 4, 2023
@lucaspoffo
Copy link
Owner

Thanks!

@lucaspoffo lucaspoffo mentioned this pull request Oct 4, 2023
Closed
@UkoeHB UkoeHB deleted the auth_update branch October 4, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UkoeHB @lucaspoffo