Switch from using u64 client id to wrapper ClientId type
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some small adjustments for the ClientId <-> u64 switch
|
Thanks! Did some adjustments to pass the CI and moved the type to the lib.rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #41
I had a rough time solving the merge conflicts from my last pull request, so I just forced my fork to upstream, that seems to have automatically closed my previous PR.
Changes
ClientIdtype in renet/src/server.rsrenewnow has aserdefeature, which addsSerializationandDeserializationimpls forClientIdwhen enabled.I tried to take all the feedback from the previous PR, and apply it to this one