Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands to objects #48

Closed
wants to merge 8 commits into from

Conversation

day01
Copy link
Contributor

@day01 day01 commented Mar 15, 2018

Moving commands into objects. PR will be more readable after #44

@day01 day01 changed the title Feature/commands to objects commands to objects Mar 15, 2018
@day01
Copy link
Contributor Author

day01 commented Mar 19, 2018

@lucaslorentz please decline the PR.

@lucaslorentz
Copy link
Owner

Are you going to create a new one?
I hope you do. 😄
A suggestion for the new one is to not merge class Uninstrumenter with the UninstrumentCommand, that's because they will probably be split again when we do this: #31
Thanks

@day01
Copy link
Contributor Author

day01 commented Mar 19, 2018

Yep, it will be the new one.. ., it will be easier than actual ;)
At the start u will see a report moving ;p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants