Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only start PMTUD after handshake confirmation #3138

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

marten-seemann
Copy link
Member

Replacement for #3121.

Our PMTUD packets are never coalesced packets. Since we try packing coalesced packets until the handshake is confirmed, it makes sense to start PMTUD then.

Our PMTUD packets are never coalesced packets. Since we try packing
coalesced packets until the handshake is confirmed, it makes sense to start
PMTUD then.
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #3138 (91629cd) into master (3376a9f) will decrease coverage by 0.01%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3138      +/-   ##
==========================================
- Coverage   85.48%   85.47%   -0.01%     
==========================================
  Files         131      131              
  Lines        9650     9650              
==========================================
- Hits         8249     8248       -1     
- Misses       1033     1034       +1     
  Partials      368      368              
Impacted Files Coverage Δ
session.go 77.10% <77.27%> (ø)
internal/utils/rand.go 62.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3376a9f...91629cd. Read the comment docs.

@marten-seemann marten-seemann merged commit 7f55fc7 into master Apr 2, 2021
@marten-seemann marten-seemann deleted the pmtud-after-handshake-confirmation branch April 2, 2021 11:20
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant