This repository has been archived by the owner on Sep 6, 2020. It is now read-only.
Updated command list and "argument-constants" highlighting to CMake version 3.14 #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Intro
Hello, I am a regular user of Atom Editor together with the language-cmake extension. I have noticed that it has not been updated for a while, which means it's syntax highlighting rules are not up to date with current CMake releases.
I have created this pull request containing updated
cmake listfile.cson
file, specifically theargument-constants
array and the command list above. CMake commit 4aace9b0 was used for extraction (version 3.14).To extract the
argument-constants
array, I digged an old Ruby script and made few changes to make it working again:arg_separators.rb
.To extract the list of commands, simple
cmake --help-command-list
was sufficient.2. Changes
The command list only has several new commands:
However, the
argument-constants
array has many new entries:There are several identifiers that weren't extracted by the
arg_separators.rb
script and are therefore removed by my commit:3. Conclusion
The majority of listed identifiers looks good to me and I think that many of them deserve to be highlighted. I am currently using this version of grammar file with my
language-cmake
plugin and I enjoy the result; noticeably more words are now highlighted.I provide this pull request so that you can try it if you want. I would also appreciate comments related to the identifiers which should / should not be added.