Cut all the decay modes of the nuclides with an half life larger than 100 years #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-fiorito-11
approved these changes
Nov 17, 2022
| skip_parent : `bool`, optional, default is `False` | ||
| skip_parents : `bool`, optional, default is `False` | ||
| flag to skip the parent information | ||
| cut_hl: `bool`, optional, default is `False` |
There was a problem hiding this comment.
@EnricaBelfiore , i guess the default here should be True
| """ | ||
| Extract decay chains into dataframe. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| skip_parent : `bool`, optional, default is `False` |
There was a problem hiding this comment.
For the future, from this description it is unclear what this option does
| @@ -376,6 +380,22 @@ def get_decay_chains(self, skip_parents=False, **kwargs): | |||
| >>> rdd.get_decay_chains(skip_parents=True) | |||
| PARENT DAUGHTER YIELD LAMBDA | |||
| 0 270600 280600 1.00000e+00 4.16705e-09 | |||
|
|
|||
| Cut the dacay modes of the nuclides with an half life larger | |||
There was a problem hiding this comment.
Typo, a few times in the docstring
| Optional argument to avoid numerical fluctuations or | ||
| kwargs : `dict` | ||
| keyword arguments for method `get_decay_chains` | ||
| thereshold: `int`, optional, default is `None` |
| Thereshold: 'int' | ||
| Optional argument to avoid numerical fluctuations or | ||
| kwargs : `dict` | ||
| keyword arguments for method `get_decay_chains` |
There was a problem hiding this comment.
Kwargs are for method get_bmatrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
cut_hlto cut the decay modes of the nuclides with an half life larger than 100 years is inserted in the following methods:sandy.DecayData.get_decay_chains()sandy.DecayData.get_bmatrix()sandy.DecayData.get_qmatrix()Examples added and minor changes in docstrings