-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the order of the arguments being inputted into result.append in print() from the Type Function Runtime #1676
Conversation
Your PR is missing flag for the change and a unit test. |
Flags are easy to add. You declare a flag at the start of the file with 'Luau' at the start of the name: In the unit test file, you fetch the existing flag using |
Alright, gimme a second. |
or more time, my Github Desktop is exploded and I forgot that I had to add |
@vegorov-rbx Alright! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
This fixes
print
from the Type Function Runtime, when you use,
inside ofprint()
within a type function.Currently, in the Type Function Runtime, if you do
print(1, 2)
It's going to append
\x1
based on thesize_t
of\t
, because it's in the wrong function argument order.It's not going to use
\t
instead it creates\x1
because of a copy paste mistake from the originalprint
result.append
has a different function orderCurrently, it's the wrong order
This is the right way
Before:

After:
