Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak .def generation #428

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Unbreak .def generation #428

merged 1 commit into from
Nov 29, 2024

Conversation

lu-zero
Copy link
Owner

@lu-zero lu-zero commented Nov 29, 2024

No description provided.

@lu-zero
Copy link
Owner Author

lu-zero commented Nov 29, 2024

@cpu could you please try this and report back?

@cpu
Copy link
Contributor

cpu commented Nov 29, 2024

@lu-zero I built/installed this branch and it worked great for my example-ffi test repo 🎉 Thanks for the very quick fix.

@cpu
Copy link
Contributor

cpu commented Nov 29, 2024

it worked great for my example-ffi test repo

And for what it's worth, also for rustls-ffi, where I started down this road originally 🔒

@lu-zero lu-zero changed the title wip: Unbreak .def generation Unbreak .def generation Nov 29, 2024
@lu-zero
Copy link
Owner Author

lu-zero commented Nov 29, 2024

Good to know, in case other problems arise:

@cpu
Copy link
Contributor

cpu commented Nov 29, 2024

in case other problems arise:

Thanks for sharing these resources 🙇

@lu-zero lu-zero merged commit b022ff1 into master Nov 29, 2024
34 checks passed
@lu-zero lu-zero deleted the msvc-def-gen branch November 29, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants