-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Meson parity #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
reviewed
May 4, 2024
lu-zero
reviewed
May 4, 2024
lu-zero
reviewed
May 4, 2024
lu-zero
reviewed
May 4, 2024
lu-zero
reviewed
May 4, 2024
lu-zero
reviewed
May 4, 2024
lu-zero
reviewed
May 14, 2024
lu-zero
reviewed
May 28, 2024
1b46030
to
7b3c02a
Compare
I fixed most I could, but I do not have window to fix the last bit. |
Looks like there is some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lu-zero,
This PR tries to implement the necessary bits to support the following Meson conventions:
libdir
under Debian distroslibfoo.a
and import librariesfoo.lib
under MSVCThe second item is done in a way that allows adding support for other OSes (as what's needed is passing
-C split-debuginfo=packed
, and this is the default on macOS).Setting it as draft before testing; will do so later next week, but I wanted to get some early feedback first.
cc @nirbheek
Fixes #279
Fixes #280
Fixes #317