Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add settings to define Require(.private) in pc file #143

Merged
merged 1 commit into from
Nov 25, 2020
Merged

add settings to define Require(.private) in pc file #143

merged 1 commit into from
Nov 25, 2020

Conversation

gdesmott
Copy link
Contributor

Fix #139

@gdesmott gdesmott mentioned this pull request Nov 25, 2020
Closed
lu-zero
lu-zero approved these changes Nov 25, 2020
View reviewed changes
Copy link
Owner

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Using ["gstreamer-1.0", "gstreamer-base-1.0"] would avoid the split + trim on input, but I guess the overall ergonomy would not improve at all. :)

@gdesmott
Copy link
Contributor Author

Yeah, I figured it was best to make things simpler for users. :)

@lu-zero lu-zero merged commit 99bc78c into lu-zero:master Nov 25, 2020
@gdesmott
Copy link
Contributor Author

gdesmott commented Dec 1, 2020

@lu-zero : we may need something more flexible for crates which dependencies are either built-in or dynamically linked, see https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/439#note_713208
What do you think?

@lu-zero
Copy link
Owner

lu-zero commented Dec 1, 2020

In theory we'd need to ask the dependencies what they did in a more robust fashion. Shall we brainstorm a little on zulip?

@gdesmott
Copy link
Contributor Author

gdesmott commented Dec 1, 2020

I never used Zulip but why not.
@sdroege may be interested discussing this as well.

@lu-zero
Copy link
Owner

lu-zero commented Dec 1, 2020

https://rust-av.zulipchat.com/#narrow/stream/254255-cargo-c/topic/Extending.20the.20pkg-config.20support for new to it

@gdesmott gdesmott mentioned this pull request Dec 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg-config: allow to define Requires and Requires.private
2 participants
@gdesmott @lu-zero