Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Error while searching for multiple entries with smarty 4.3.4 (#108) #109

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix Error while searching for multiple entries with smarty 4.3.4 (#108) #109

merged 1 commit into from
Oct 31, 2023

Conversation

davidcoutadeur
Copy link

fixes #108

@coudot
Copy link
Member

coudot commented Oct 31, 2023

In which case would listing_sortby not be an integer?

@davidcoutadeur
Copy link
Author

in the case it is not found in the listing of search attributes, then the array_search returns a boolean (false)

I imagined that was the reason for the previous default:0+1

@coudot
Copy link
Member

coudot commented Oct 31, 2023

Indeed. Thanks for the fix.

@coudot coudot added this to the 0.6 milestone Oct 31, 2023
@coudot coudot added the bug Something isn't working label Oct 31, 2023
@coudot coudot merged commit e94be04 into ltb-project:master Oct 31, 2023
@davidcoutadeur davidcoutadeur deleted the 108-listing_sortby branch October 31, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

Error while searching for multiple entries with smarty 4.3.4
2 participants
@davidcoutadeur @coudot