Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display localized time #110

Closed
davidcoutadeur opened this issue Nov 24, 2023 · 6 comments · Fixed by #111
Closed

Display localized time #110

davidcoutadeur opened this issue Nov 24, 2023 · 6 comments · Fixed by #111
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@davidcoutadeur
Copy link

davidcoutadeur commented Nov 24, 2023

Currently, when an account is locked, we display the time stored in pwdAccountLockedTime.
For example:

pwdAccountLockedTime: 20231124084929Z

Self Service password displays:

Automatic unlock date: 25/11/2023 - 08:49:29 (UTC)

We could have an option to display localized time: 25/11/2023 - 09:49:29

@coudot
Copy link
Member

coudot commented Nov 24, 2023

The time format can be configured with $date_specifiers: https://service-desk.readthedocs.io/en/stable/general-parameters.html#dates

So you can easily display the UTC information

We should indeed add a feature to change the time zone

@coudot coudot added this to the 0.6 milestone Nov 24, 2023
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Nov 24, 2023

Seems the date is already configured to display the timezone, but it is not working:

$date_specifiers = "%Y-%m-%d %H:%M:%S (%Z)"
<p>{$msg_unlockdate} {$unlockDate|date_format:{$date_specifiers}}</p>

Maybe a bug in smarty or a feature not available in our version

@coudot coudot added the enhancement New feature or request label Nov 24, 2023
@coudot
Copy link
Member

coudot commented Nov 24, 2023

@coudot
Copy link
Member

coudot commented Nov 24, 2023

@davidcoutadeur
Copy link
Author

davidcoutadeur commented Nov 24, 2023

The date_specifiers was overloaded somewhere. Sorry for the noise.

I keep the issue opened for the new feature to display localized time, which could be interesting IMO.

@davidcoutadeur
Copy link
Author

Should be ok with #111

@davidcoutadeur davidcoutadeur self-assigned this Jan 5, 2024
coudot added a commit that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants