Skip to content

FIREFLY-1187: Add more TAP ObsCore options #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented May 1, 2024

Check Caltech-IPAC/firefly#1552 for context and testing instructions

NOTE: this is for testing purpose, and will need input from scientists for perfecting the options and tooltip/placeholder wordings

  • Don't need placeholder because options are fetched
  • Add "enableMetadataLoad" to indicate it needs to be fetched for this service

FIREFLY-1187: Add list options for tapObsCore

FIREFLY-1187: Remove options from config

FIREFLY-1187: Address PR comments
@jaladh-singhal jaladh-singhal force-pushed the FIREFLY-1187-obscore-options branch from 8723bda to 5587276 Compare May 22, 2024 23:25
@jaladh-singhal jaladh-singhal merged commit 2e6d957 into main May 22, 2024
1 check passed
@jaladh-singhal jaladh-singhal deleted the FIREFLY-1187-obscore-options branch May 22, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants