Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48940: Modify DEBUG logging test to be more robust #1144

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

timj
Copy link
Member

@timj timj commented Jan 17, 2025

Rather than assuming that log message N is a debug message, check that any debug messages appeared when debug logging was enabled. This works around issues where CLI plugins could inject their own log messages.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Rather than assuming that log message N is a debug message,
check that any debug messages appeared when debug logging was
enabled. This works around issues where CLI plugins could
inject their own log messages.
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (e3be3c4) to head (b9ebac3).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
- Coverage   89.49%   89.49%   -0.01%     
==========================================
  Files         366      366              
  Lines       49020    49018       -2     
  Branches     5941     5941              
==========================================
- Hits        43872    43870       -2     
  Misses       3733     3733              
  Partials     1415     1415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 524ffd8 into main Jan 17, 2025
19 checks passed
@timj timj deleted the tickets/DM-48490 branch January 17, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants