DM-37951: Allow PTC analysis to split each amp into subregions #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
reviewed
Feb 13, 2023
|
|
||
| # interpolate + smooth | ||
| itp = interp1d(x,y, kind='linear') | ||
| window_size, poly_order = 101, 3 |
There was a problem hiding this comment.
These should probably be config options. Was 101 chosen for a particular reason, or is just "an odd integer about 100"?
| # Now split the region into subregions | ||
| xStep = int(region.width / nSubX) | ||
| yStep = int(region.height / nSubY) | ||
| for iSub in range(nSubX): |
There was a problem hiding this comment.
It's probably not worth the effort now, but this could have used the cpCombine.CpCombineTask._subBBoxIter static method to chunk the image and reuse code.
| for ampName in ampNames: | ||
| datasetPtc.inputExpIdPairs[ampName].append(partialPtcDataset.inputExpIdPairs[ampName]) |
There was a problem hiding this comment.
Doesn't this change the dimensionality? Previously the partial inputs were lists of tuples, appended into a list-of-list-of-tuples. Using += flattens it into a list-of-tuples again. I think this less of a problem below, as it looks like it was just selecting the first element of the input lists for those entries.
plazas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working, but I'm sure has things that need correcting. Summary of the status is in the Jira ticket.