Change 'filters' to 'bands' for multiband images and exposures #773
Conversation
| """ | ||
| return self._filters |
There was a problem hiding this comment.
I'd suggest keeping this for now, but deprecating it while adding bands as a new property.
There was a problem hiding this comment.
This appeared a few rows below where I intended. I meant to keep filters as a property, not _filters attribute.
fred3m
force-pushed
the
tickets/DM-36099
branch
2 times, most recently
from
48afcbc to
edd15db
Compare
python/lsst/afw/multiband.py
Outdated
| Use `bands` instead. | ||
| """ | ||
| warnings.warn("Use `bands` instead of `filters`", DeprecationWarning) |
There was a problem hiding this comment.
You could use the same prescription to deprecate the staticmethod so it appears in the documentation as well.
https://developer.lsst.io/stack/deprecating-interfaces.html#python-deprecation
There was a problem hiding this comment.
I initially tried that but unfortunately it doesn't work for properties.
There was a problem hiding this comment.
Hmm, I tried it locally before commenting this. The order matters - property on top and deprecated below that.
There was a problem hiding this comment.
Oh... it's because I forgot to import deprecated. :(
fred3m
force-pushed
the
tickets/DM-36099
branch
from
edd15db to
c52281b
Compare
No description provided.