DM-49333: Allow PropertySet to be passed to afw display #769
+246
−631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2025
timj
commented
Mar 11, 2025
timj
commented
Mar 11, 2025
|
|
||
| # Now WcsB, so that pixel (0,0) is correctly labelled (but ignoring XY0) | ||
| # Ignored by writeFits below | ||
| _add_wcs("B", ps) |
There was a problem hiding this comment.
Consensus is that I'm going to drop this.
| else: | ||
| raise TypeError(f"Unsupported type {data!r}") | ||
|
|
||
| def mtv(self, data, title="", wcs=None): | ||
| def mtv(self, data, title="", wcs=None, metadata=None): | ||
| """Display an image on a display, with semi-transparent masks | ||
| overlaid, if available. | ||
There was a problem hiding this comment.
It's somewhat separate from this ticket, but it would be good to at least point to image in the docstring so one would know where to go and look up the parameters for mtv.
arunkannawadi
approved these changes
Mar 18, 2025
Also support native subprocess.Popen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.