Object detection controller #19
Conversation
new file: forcedphot/odc.py new file: forcedphot/query_args.txt
new file: tests/forcedphot/test_odc.py
modified: tests/forcedphot/ephemeris/test_data_loader.py modified: tests/forcedphot/test_odc.py
…000_2024-06-30_23-59-00.000.ecsv
modified: src/forcedphot/ephemeris/horizons_interface.py modified: src/forcedphot/ephemeris/miriade_interface.py modified: src/forcedphot/odc.py modified: tests/forcedphot/ephemeris/test_ephemeris_client.py modified: tests/forcedphot/ephemeris/test_horizons_interface.py modified: tests/forcedphot/ephemeris/test_miriade_interface.py
modified: src/forcedphot/ephemeris/ephemeris_client.py modified: src/forcedphot/odc.py modified: tests/forcedphot/ephemeris/test_data_loader.py modified: tests/forcedphot/test_odc.py
modified: tests/forcedphot/test_odc.py
|
Thank you for your contribution to ssoforcedphot, a LINCC Framework package! 🌌 This checklist is meant to remind pull request reviewers of some common things to look for.
|
| else: | ||
| self.parser.error("Either provide a CSV/ECSV file or all single query parameters") | ||
|
|
||
| def run(self): |
There was a problem hiding this comment.
If this is going to become part of a handler in a webserver or API or some kind, I would want to separate out the argument parsing from the actual controller logic. In other words, the function where we step through all the different services should probably take its arguments directly rather than from a self.args.
| --ecsv: | ||
| Path to ECSV file containing input data. | ||
|
|
||
| --csv: |
There was a problem hiding this comment.
should give more info on how the csv file should be set up. Based on the test file, it looks like the column headers are named the specific args? But I may be wrong here.
There was a problem hiding this comment.
if used for tests, should be moved a data directory in tests or if it's being used as an example, it should probably still go elsewhere.
| service selection, target specification, time range settings, input file | ||
| handling, and various service configurations. | ||
|
|
||
| Command-line Arguments: |
There was a problem hiding this comment.
The filter(s) a user wants to query should be an argument for all but the ephemeris service. It should be able to receive a single filter or list of filters (e.g., [g,r])
Change Description
I have created the objection detection controller (odc) which brings together and manages the various subsystems, such as the ephemeris service, the image service, etc.
Currently it only manages the ephemeris service via command line interface.