Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port library to TypeScript #374

Merged
merged 13 commits into from
Aug 3, 2022
Merged

Port library to TypeScript #374

merged 13 commits into from
Aug 3, 2022

Conversation

dominik-korsa
Copy link
Contributor

@dominik-korsa dominik-korsa commented Dec 5, 2021 •
edited
Loading

Migrated packages:

Other changes:

  • tests
  • examples

Some of the changes in this PR are breaking. Here is a list of some of them:

  • Printer.getStatus takes (a constructor of) a status class instead of it's the class name
  • All callbacks of the Printer methods have been converted to promises. This means chaining on methods returning a promise is no longer possible. (This could potentially be solved by implementing both Promise (or PromiseLike) and Printer in the returned value.

@lsongdev
Copy link
Owner

lsongdev commented Dec 6, 2021

#375

@lsongdev lsongdev marked this pull request as ready for review December 6, 2021 04:51
@dominik-korsa
Copy link
Contributor Author

Are you going to merge this PR any time soon?

@lsongdev lsongdev merged commit cdcc69c into lsongdev:v3 Aug 3, 2022
@1EDExg0ffyXfTEqdIUAYNZGnCeajIxMWd2vaQeP
Copy link

Can you publish v3 with type information to npm. We only have @types/escpos and it's out of date and also wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsongdev lsongdev lsongdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominik-korsa @lsongdev @1EDExg0ffyXfTEqdIUAYNZGnCeajIxMWd2vaQeP