Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v hbb e iso dec27 94 x #1

Closed
wants to merge 5 commits into from
Closed

Add v hbb e iso dec27 94 x #1

wants to merge 5 commits into from

Conversation

capalmer85
Copy link

No description provided.

@lsoffi
Copy link
Owner

lsoffi commented Jan 8, 2018

@michelif @fcouderc Hi Chris, we are working on merging this PR. We solved a small conflict in the TnP code but when trying to test it running before the merge, we are getting the following error:
[soffi@lxplus088 TnPTreeProducer]$ cmsRun python/TnPTreeProducer_cfg.py doEleID=True isMC=False maxEvents=50
----- Begin Fatal Exception 08-Jan-2018 14:00:50 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
[0] Processing the python configuration file named python/TnPTreeProducer_cfg.py
Exception Message:
python encountered the error: <type 'exceptions.ImportError'>
No module named egmGedGsfElectronMiniIsolation_cfi
----- End Fatal Exception -------------------------------------------------

This is because in the 9-4-0-pre3 CMSSW release the following cfi are missing:

python/egmElectronMiniIsoModules_cff.py: from RecoEgamma.EgammaIsolationAlgos.egmGedGsfElectronMiniIsolation_cfi import egmGedGsfElectronMiniNoPileUpIsolation
python/egmElectronMiniIsoModules_cff.py: from RecoEgamma.EgammaIsolationAlgos.egmGedGsfElectronMiniIsolation_cfi import egmGedGsfElectronEffAreaMiniIsolation

Do you have them in a private release?
Thanks
Livia && Francesco

@capalmer85
Copy link
Author

Hi Livia,

That file (RecoEgamma/EgammaIsolationAlgos/python/egmGedGsfElectronMiniIsolation_cfi.py) isn't part of this package. Since they are part of the CMSSW package, I assume that they have to be included by a cms-merge from a different branch. I just started from your branch and added the tree branches I needed on top of that. (It worked in 941.)

I was just looking for this file and I don't actually find it in any 9_4_X or 10_0_X branches. Do you know where this file comes from? (I didn't make it.)

Cheers,
Chris

@lsoffi
Copy link
Owner

lsoffi commented Jan 9, 2018

@fcouderc @michelif Hi Chris,

indeed they are not in 94x. In which release did you test your TnP branch? Did it work for you the test with the cmsRun?

Thanks

Livia

@capalmer85
Copy link
Author

I didn't test it with cmsRun. The only two lines that I actually added were:

el_sumPUPt = cms.string("pfIsolationVariables().sumPUPt"),
el_reliso03 = cms.string("(pfIsolationVariables().sumChargedHadronPt + max(pfIsolationVariables().sumNeutralHadronEt + pfIsolationVariables().sumPhotonEt - 0.5 * pfIsolationVariables().sumPUPt,0.0)) / pt() "),

in python/egmTreesContent_cff.py. I copied these from an area that was working and tested.

@capalmer85
Copy link
Author

capalmer85 commented Jan 9, 2018 via email

@lsoffi
Copy link
Owner

lsoffi commented Jan 9, 2018

Hi Chris,
let me have a look.
Thanks
Livia

@fcouderc
Copy link

@lsoffi
the MiniIso was added by Saranya ( @saghosh )
Could you check with him if this is the problem ? I thought it was working though.
May be some files were missing.

Fabrice

@lsoffi
Copy link
Owner

lsoffi commented Jan 10, 2018

Hi @capalmer85 ,
i checked the instructions and fixed the extra space.
The problem is not in the code, but there are few problematic events where the code crashes. Indeed if you test on another file you can run over 5k events w/o problems. I am investigating what is the problem in these events (potentially no pairs of Tag and Probe are found), but for the moment you can test your branch on 3k events, or use another file. I`ll add here an update once i figure out the solution. Best
Livia

@capalmer85
Copy link
Author

capalmer85 commented Jan 10, 2018 via email •
edited
Loading

@lsoffi
Copy link
Owner

lsoffi commented Jan 11, 2018

Hi Chris, thanks. Meanwhile we fixed the isse with the crash. I will update it and try again your merge in the next hours.
Best
Livia

@lsoffi
Copy link
Owner

lsoffi commented Mar 6, 2018

I close this PR b/c the fix has been implemented and committed already.

@lsoffi lsoffi closed this Mar 6, 2018
sansan9401 pushed a commit to sansan9401/EgammaAnalysis-TnPTreeProducer that referenced this pull request Nov 30, 2019
@swagata87
Merge pull request lsoffi#1 from tomcornelis/Nm1_proposedUpdates
d850acf 
Nm1 proposed updates
sansan9401 pushed a commit to sansan9401/EgammaAnalysis-TnPTreeProducer that referenced this pull request Dec 9, 2020
@lfinco
Merge pull request lsoffi#1 from tomcornelis/lfinco
784560a 
Attempt to have the L1 leg thresholds based on prescale
sansan9401 pushed a commit to sansan9401/EgammaAnalysis-TnPTreeProducer that referenced this pull request Dec 9, 2020
@tomcornelis
Merge pull request lsoffi#1 from guitargeek/VVV_patch
b8acc18 
Implement el_relPfLepIso03 and passingDoubleHLTsafe for Triboson Analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@capalmer85 @lsoffi @fcouderc @saghosh