Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed encoding magic comment that broke ruby 1.9.3 #1090

Closed
wants to merge 1 commit into from
Closed

Fixed encoding magic comment that broke ruby 1.9.3 #1090

wants to merge 1 commit into from

Conversation

jessebs
Copy link

@jessebs jessebs commented Apr 25, 2017

Description

Fix for #1089

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

coveralls commented Apr 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 93.463% when pulling d36dea2 on jessebs:master into 0271dab on lsegal:master.

@jessebs jessebs mentioned this pull request Apr 25, 2017
Closed
@lsegal
Copy link
Owner

lsegal commented Apr 25, 2017

Sorry I hadn't seen this when I went in to fix. Thanks for making this, though!

@lsegal lsegal closed this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebs @coveralls @lsegal