Implement hook to pass cpuinfo to LKL with test #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
requested changes
Aug 18, 2020
davidchisnall
approved these changes
Sep 7, 2020
AntonioND
changed the title
This includes the hooks and tests for /proc/cpuinfo support.
For cpuinfo, the correct hook has been implemented in this commit.
This test makes sure that the number of CPUs is the same number as ethreads. The environment variable SGXLKL_ETHREADS is set to an arbitrary value (in the current code, 4) and the same number is passed as a command line argument to the binary ``cpuinfo``, which verifies that the number of CPUs in the emulated system matches the number passed on the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on lsds/lkl#7 being merged. It has to be rebased and the gitmodules reference has to be updated.