Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release checklist, cleanup version output, add release pipeline #255

Merged
merged 11 commits into from
Jun 5, 2020

Conversation

letmaik
Copy link
Contributor

@letmaik letmaik commented May 15, 2020

First steps towards #237.

Please have a look at this, obviously this will evolve a lot over time, but we need to get the ball rolling.

  • Added a release process checklist, inspired by https://github.com/microsoft/vscode/wiki/Release-Process.
  • Changed the info/version string such that both the SGX-LKL version (from VERSION file) and git commit hash is included in the binary and the command line output.
  • Created a new release pipeline (and other minor CI refactoring) which can be used to release new versions to the release apt repository (as opposed to the dev apt repository that is used for all dev releases triggered by commits to oe_port).

@letmaik letmaik added the area: ci/cd Testing and CI label May 15, 2020
@letmaik letmaik force-pushed the letmaik/version branch from 49db8d2 to ecdcdd6 Compare May 15, 2020 15:51
@letmaik letmaik force-pushed the letmaik/version branch from ecdcdd6 to 17ff221 Compare May 15, 2020 15:52
@letmaik letmaik marked this pull request as ready for review May 18, 2020 13:53
@letmaik letmaik changed the title Cleanup versions & add release checklist Add release checklist, cleanup version output, add release pipeline May 18, 2020
@letmaik letmaik requested review from davidchisnall and prp May 18, 2020 13:55
@letmaik
Copy link
Contributor Author

letmaik commented May 26, 2020

@prp @davidchisnall @paulcallen Please provide feedback and/or approve. PRs shouldn't sit idle for more than a day or two.

Copy link
Collaborator

@hukoyu hukoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@letmaik letmaik removed request for davidchisnall and prp June 4, 2020 08:46
@letmaik letmaik merged commit be64f45 into oe_port Jun 5, 2020
@letmaik letmaik deleted the letmaik/version branch June 5, 2020 09:05
@letmaik
Copy link
Contributor Author

letmaik commented Jun 5, 2020

@jxyang @Pengpeng-Microsoft Since you haven't responded I'm assuming it's all fine. It's merged in now. Please open an issue if anything should change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci/cd Testing and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants