Skip to content

Commit

Permalink
blktrace: use existing disk debugfs directory
Browse files Browse the repository at this point in the history
We may already have a directory to put the blktrace stuff in if

1. The disk uses blk-mq
2. CONFIG_BLK_DEBUG_FS is enabled
3. We are tracing the whole disk and not a partition

Instead of hardcoding this very specific case, let's use the new
debugfs_lookup(). If the directory exists, we use it, otherwise we
create one and clean it up later.

Fixes: 07e4fea ("blk-mq: create debugfs directory tree")
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
osandov authored and axboe committed Feb 2, 2017
1 parent 62ebce1 commit 6ac9311
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions kernel/trace/blktrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -470,12 +470,12 @@ static int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (!blk_debugfs_root)
goto err;

dir = debugfs_create_dir(buts->name, blk_debugfs_root);

dir = debugfs_lookup(buts->name, blk_debugfs_root);
if (!dir)
bt->dir = dir = debugfs_create_dir(buts->name, blk_debugfs_root);
if (!dir)
goto err;

bt->dir = dir;
bt->dev = dev;
atomic_set(&bt->dropped, 0);
INIT_LIST_HEAD(&bt->running_list);
Expand Down Expand Up @@ -517,9 +517,12 @@ static int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (atomic_inc_return(&blk_probes_ref) == 1)
blk_register_tracepoints();

return 0;
ret = 0;
err:
blk_trace_free(bt);
if (dir && !bt->dir)
dput(dir);
if (ret)
blk_trace_free(bt);
return ret;
}

Expand Down

0 comments on commit 6ac9311

Please sign in to comment.