-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posthook don't log script errors #262
Comments
I have a suggestion: have different levels for STDOUT and STDERR. Seems easy to add an option in printHookOutput to set the logback level. I would choose DEBUG or INFO for STDOUR and ERROR for STDERR, instead of having WARN for both. What do you think @davidcoutadeur ? |
Why not, it does not seem too difficult indeed. Note: until know, the script were not supposed to write things to stdout/stderr, we should update the documentation:
|
Done in commit 40d80fe I have set level INFO for stdout and ERROR for stderr I am updating the corresponding documentation right now. |
See also corresponding issue on main lsc project: lsc-project/lsc#262
Currently, posthook don't log script errors (see https://lsc-project.org/documentation/latest/syncrules.html#hooks-lsc-tasks-task-propertiesbasedsyncoptions-hooks)
It could be nice to log script stderr (and maybe also stdout?)
We need to check if this has an impact on performances
The text was updated successfully, but these errors were encountered: