Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing security relevant dependencies #702

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Fixing security relevant dependencies #702

merged 4 commits into from
Nov 19, 2024

Conversation

niclasheun
Copy link
Collaborator

Changes

This PR shall fix the outdated dependencies, that might cause a security concern.

Changes on Client side

I fixed all issues that where found by yarn npm audit. I issue remains unsolved (-> see below).

Changes on Server Side

  • updated jgit
  • updated spring boot version to 3.2.11
  • added the whitesource config file (copied from Artemis and adjusted to fit the Prompt project setup)

How the changes where tested

I tested all dependency changes locally and manually tested if Prompt still works correctly (due to the non existence of automated tests).

Issues / Open Questions

  • @Mtze Mend/Whitesource runner needs to be added to this repo (to check for potential additional issues)
  • On the client side, the react-beautiful-dnd warning is still unresolved. Pasted Graphic
    This plugin is used in two places:
    -- The course phase manager, which is a currently unused feature
    -- The post kickoff submission form, which we plan to not use any more (since till then we want to have introduced Prompt 2.0).
    Hence, I am not sure if we need to really address this deprecated warning.

@niclasheun niclasheun requested a review from Mtze November 19, 2024 12:42
@niclasheun niclasheun self-assigned this Nov 19, 2024
@Mtze Mtze merged commit ece9f8d into main Nov 19, 2024
2 of 3 checks passed
@Mtze Mtze deleted the security-patches branch November 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants