Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Add pull request deployment using Helm #9689

Closed

Conversation

kliwniloc
Copy link

@kliwniloc kliwniloc commented Nov 6, 2024

Demo please ignore

Summary by CodeRabbit

Release Notes

  • Documentation

    • Added a new test server entry for Kubernetes deployment.
    • Expanded GitHub Deployment section with detailed steps for Kubernetes deployment.
    • Introduced access instructions in the Helm chart's NOTES.txt based on service type.
  • Chores

    • Updated .gitignore to exclude charts directory from version control.
  • New Features

    • Enhanced Helm chart with new template definitions for improved configurability and usability.

Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Bump versions for Chart and appVersion.

Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Add url for k8s env

Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Add condition to check if delpoy:k8s tag exists for the PR

Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Set cancel-in-progress to true so that in scenarios where commits are
pushed fast or multiple tags are added at once we only run the most
recent pipeline.

Signed-off-by: Colin Wilk <colin.wilk@tum.de>
Copy link

coderabbitai bot commented Nov 6, 2024

Warning

Rate limit exceeded

@kliwniloc has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between fdc2501 and f4da4ed.

Walkthrough

The pull request introduces updates to the documentation and Helm chart templates for the Artemis application. A new test server entry has been added to the documentation, along with expanded instructions for deploying to Kubernetes via GitHub. Additionally, new templates have been created in the Helm chart to enhance configurability, including definitions for naming conventions and common labels. The .gitignore file has also been modified to ignore the charts directory.

Changes

File Path Change Summary
docs/dev/testservers.rst Added new test server entry https://pr*.artemis-k8s.ase.cit.tum.de and expanded GitHub Deployment instructions for Kubernetes.
helm/.gitignore Added entry to ignore charts directory.
helm/artemis/templates/NOTES.txt Introduced new access instructions based on service type in the Helm chart's NOTES.txt.
helm/artemis/templates/_helpers.tpl Added multiple template definitions for naming conventions and labels in the Helm chart.

Possibly related PRs

  • Development: Update test server documentation #8790: This PR updates the test server documentation, which directly relates to the changes made in the main PR regarding the addition of a new test server entry and modifications to deployment instructions in docs/dev/testservers.rst.

Suggested labels

documentation, component:Programming, docker, ready for review

Suggested reviewers

  • b-fein
  • krusche
  • yassinsws
  • magaupp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant