Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix DOM event name conflicts #9589

Merged
merged 10 commits into from
Oct 27, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export class TextblockFeedbackEditorComponent implements AfterViewInit {
@Input() textBlock: TextBlock = new TextBlock();
@Input() feedback: Feedback = new Feedback();
@Output() feedbackChange = new EventEmitter<Feedback>();
// eslint-disable-next-line @angular-eslint/no-output-native
florian-glombik marked this conversation as resolved.
Show resolved Hide resolved
@Output() close = new EventEmitter<void>();
@Output() onFocus = new EventEmitter<void>();
@ViewChild('detailText') textareaRef: ElementRef;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
})
export class FormFooterComponent {
@Output() save = new EventEmitter<void>();
// eslint-disable-next-line @angular-eslint/no-output-native

@Output() cancel = new EventEmitter<void>();

Check failure on line 14 in src/main/webapp/app/forms/form-footer/form-footer.component.ts

View workflow job for this annotation

GitHub Actions / client-style

Output bindings, including aliases, should not be named as standard DOM events
florian-glombik marked this conversation as resolved.
Show resolved Hide resolved

@Input() isSaving: boolean = false;
@Input() isDisabled: boolean = false;
Expand Down
Loading