Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive learning: Explain course competency view #9511

Merged
merged 10 commits into from
Oct 19, 2024

Conversation

JohannesWt
Copy link
Contributor

@JohannesWt JohannesWt commented Oct 18, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Currently there is no intuitive explanation for the competencies and adaptive learning feature.

Description

This PR introduces a modal which explains the competencies and adaptive learning feature.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Programming Exercise with Complaints enabled
  1. Log in to Artemis
  2. Navigate to Competency management page
  3. Open the help window

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

image

Summary by CodeRabbit

  • New Features
    • Introduced a help button in the competency management interface for enhanced user support.
    • Added a modal for course competency explanations, providing detailed guidance on adaptive learning and competency relationships.
  • Bug Fixes
    • Improved localization support with new and updated translations for German and English.
  • Documentation
    • Expanded instructional content within the user interface to clarify functionalities and processes related to competency management.

@JohannesWt JohannesWt self-assigned this Oct 18, 2024
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 18, 2024
@JohannesWt JohannesWt temporarily deployed to artemis-test1.artemis.cit.tum.de October 18, 2024 10:48 — with GitHub Actions Inactive
@JohannesWt JohannesWt changed the title Adaptive Learning: Course competency explanation view Adaptive Learning: Course competency explanation view Oct 18, 2024
@JohannesWt JohannesWt changed the title Adaptive Learning: Course competency explanation view Adaptive learning: Course competency explanation view Oct 18, 2024
Copy link

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test4.artemis.cit.tum.de" is already in use by PR #9460.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Oct 18, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Copy link

@sachmii sachmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS4, works fine.

@krusche krusche added this to the 7.6.1 milestone Oct 19, 2024
Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition for instructors who use the feature for the first time. Thank you 👍

@krusche krusche changed the title Adaptive learning: Course competency explanation view Adaptive learning: Explain course competency view Oct 19, 2024
@krusche krusche merged commit a0d7a97 into develop Oct 19, 2024
38 of 42 checks passed
@krusche krusche deleted the feature/adaptive-learning/feature-explanation-view branch October 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) small
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants