-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning paths
: Redesign learning path instructor view
#9144
Learning paths
: Redesign learning path instructor view
#9144
Conversation
…ningPathService.java Co-authored-by: Johannes Stöhr <38322605+JohannesStoehr@users.noreply.github.com>
…feature/learning-paths/refactor-instructor-view # Conflicts: # src/main/java/de/tum/in/www1/artemis/web/rest/dto/competency/CompetencyGraphNodeDTO.java # src/main/webapp/app/entities/competency/learning-path.model.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainer approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- src/main/java/de/tum/cit/aet/artemis/atlas/web/LearningPathResource.java (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/java/de/tum/cit/aet/artemis/atlas/web/LearningPathResource.java (1)
Pattern
src/main/java/**/*.java
: naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports
src/main/java/de/tum/cit/aet/artemis/atlas/web/LearningPathResource.java
Show resolved
Hide resolved
Learning paths
: Refactor learning path instructor viewLearning path
: Refactor learning path instructor view
Learning path
: Refactor learning path instructor viewLearning path
: Redesign learning path instructor view
Learning path
: Redesign learning path instructor viewLearning paths
: Redesign learning path instructor view
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
The current instructor view for the learning path feature only displays the learning paths of students in the course. To provide a clearer overview, the instructor view should be redesigned to include more aggregated data.
Description
This PR introduces a new design for the learning path instructor view. Notifications about whether everything is set up correctly, which were previously displayed at the top of the learning paths table, now have a dedicated section. In this section, the instructor is alerted if competencies or their relationships need to be created, or if some student learning paths have not yet been generated. These notifications are represented by small, color-coded banners indicating the severity of the issue.
Additionally, the learning paths table has been simplified and slightly redesigned. A new analysis section has also been introduced, which provides more aggregated data for the entire course. This section includes a competency path that shows the average mastery of competencies, offering the instructor a clearer overview of student progress.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Client
Screenshots
Before
After
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores
LearningPathHealthDTO
to remove the "OK" status from the health status enum.