-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive learning
: Improve prerequisite import
#8658
Adaptive learning
: Improve prerequisite import
#8658
Conversation
Development
: Add prerequisite entitiesAdaptive Learning
: Improve Prerequisite Import
Adaptive Learning
: Improve Prerequisite ImportAdaptive learning
: Improve Prerequisite Import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the migration with production data and it works fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove Code after merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested again on TS1, works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual test on TS1. Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new changes lgtm! (re-approve)
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
We want to refactor the prerequisite management with the goal of linking exercise units to prerequisites as
pre-tests
for a course. To support this, prerequisites need to be changed to be actual entities (before they were only references).Description
This PR adds Prerequisites as entities to the server:
Prerequisite
andCourseCompetency
(which is the new superclass ofCompetency
andPrerequisite
)competency
tocourse_competency
as it now contains allCourseCompetencies
.course_competency
tableIt also improves the prerequisite import:
Other changes:
Competency
class in the client to be an interface -> to support future use cases where we want to use the newCourseCompetency
interface for both competencies and prerequisites.Steps for Testing
Needed:
1 Instructor
Another course with competencies (you can use Raphael Stief Test Course)
Test the new prerequisite import (select, de-select competencies, search, filter, import, ...)
Test the competency import (import from another course)
Test all other occurrences of prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Server
Screenshots
Summary by CodeRabbit
New Features
Prerequisite
andLinkedCourseCompetencyDTO
classes to enhance competency handling.Bug Fixes
Documentation
Refactor
Competency
class into interfaces for better maintainability and updated related services and repositories.Tests
Chores