Development: Fix missing aboutUs translation key
#6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #6623 +/- ##
=============================================
- Coverage 84.95% 80.29% -4.67%
+ Complexity 13331 13329 -2
=============================================
Files 1092 2369 +1277
Lines 42905 90759 +47854
Branches 4448 12803 +8355
=============================================
+ Hits 36450 72873 +36423
- Misses 4001 9809 +5808
- Partials 2454 8077 +5623 see 1278 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
❌ Unable to deploy to test servers ❌Testserver "artemis-test4.artemis.cit.tum.de" is already in use by PR #6475. |
github-actions
bot
added
the
deployment-error
DominikRemo
approved these changes
May 24, 2023
JohannesStoehr
approved these changes
May 24, 2023
4ludwig4
added
deploy:artemis-test4
and removed
deployment-error
4ludwig4
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
GitHub Actions
Inactive
|
Just tested this on Docker Compose TS4 and the about page works again. |
4ludwig4
approved these changes
May 24, 2023
terlan98
approved these changes
May 24, 2023
Mtze
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
@JohannesStoehr noticed a bug caused by #6546: The translation keys for the
about uspage had gone missing. This PR fixes that.Description
I noticed that the reported issue was caused by a small mistake in the
prebuild.mjsscript where I forgot the initial value for a call to.reduce. This caused the first filename to be the initial value, therefore the first file alphabetically (aboutUs.json) not to be considered.This PR adds an initial value.
Steps for Testing
Review Progress
tested by 4 people, 1 line of code change
Screenshots
Before:
After:
