Development: Fix server style job that fails due to known issue in spotless
#4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
server
added 2 commits
October 21, 2021 20:33
lschlesinger
changed the title
Development: Fix server-style Github workflow that breaks due to known issue
lschlesinger
changed the title
Development: Fix server-style Github workflow that breaks due to known issueDevelopment: Fix server-style Job in Github pipeline that fails due to known issue in spotless
lschlesinger
requested review from
jpbernius,
krusche and
a team
as code owners
krusche
changed the title
Development: Fix server-style Job in Github pipeline that fails due to known issue in spotlessDevelopment: Fix server style job that fails due to known issue in spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The server-style job fails since X due to an error shown in the picture.
People tend to not check the result of this job anymore, cause if "fails anyways", so a failure does not raise the awareness of the developers, which is a risk on introducing server-style issues. Furthermore, the task of removing unused imports could not be executed properly -> we had one unused import in develop, it is removed in this PR as well.
Description
This is a false positive, as it is a reported bug in
spotless-> check the according ticket here.As reported in the bugticket "that's because google-java-format now requires additional JVM flags during compilation: https://github.com/google/google-java-format/releases/tag/v1.10.0".
I applied the fix proposed in the conversation of the bugticket.
With this changes, the server-style check passes again.