Programming exercises: Display static code analysis option in programming exercise detail view
#10119
Conversation
github-actions
bot
added
the
client
magaupp
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
GitHub Actions
Inactive
magaupp
force-pushed
the
feature/programming-exercises/indicate-sca-in-detail
branch
from
d50cbf1 to
bce2fd3
Compare
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: client-tests
| { | ||
| type: DetailType.Boolean, | ||
| title: 'artemisApp.programmingExercise.enableStaticCodeAnalysis.title', | ||
| data: { boolean: exercise.staticCodeAnalysisEnabled }, | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove duplicate static code analysis detail entry.
The static code analysis status is displayed twice in the details view - once in the language section and once in the grading section. Since this is a grading-related feature, it should only appear in the grading section.
Apply this diff to remove the duplicate entry:
- {
- type: DetailType.Boolean,
- title: 'artemisApp.programmingExercise.enableStaticCodeAnalysis.title',
- data: { boolean: exercise.staticCodeAnalysisEnabled },
- },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| type: DetailType.Boolean, | |
| title: 'artemisApp.programmingExercise.enableStaticCodeAnalysis.title', | |
| data: { boolean: exercise.staticCodeAnalysisEnabled }, | |
| }, | |
| { |
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts (1)
372-376: Consider consolidating duplicate static code analysis entries.The static code analysis status is displayed in both the language section and the grading section. Consider keeping it only in the grading section as it's more related to assessment configuration than language settings.
- { - type: DetailType.Boolean, - title: 'artemisApp.programmingExercise.enableStaticCodeAnalysis.title', - data: { boolean: exercise.staticCodeAnalysisEnabled }, - },
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
|
I missed that this already exists in the Grading section. Didn't expect it there, but it does make more sense there. |
magaupp
deleted the
feature/programming-exercises/indicate-sca-in-detail
branch
Checklist
General
Client
Changes affecting Programming Exercises
Motivation and Context
During testing @ahbitaqu noticed an inconsistency in that Sequential Test Runs are shown in the details view, while Static Code Analysis is not.
Description
This PR adds an indicator for Static Code Analysis, just like the one for Sequential Test Runs.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Manual Tests
Screenshots
Summary by CodeRabbit